mrlib: really verify the revs in verify_commits
authorFrantisek Hrbata <frantisek@hrbata.com>
Thu, 10 Dec 2020 16:20:31 +0000 (17:20 +0100)
committerFrantisek Hrbata <frantisek@hrbata.com>
Thu, 10 Dec 2020 16:20:31 +0000 (17:20 +0100)
Signed-off-by: Frantisek Hrbata <frantisek@hrbata.com>
mrlib.py

index 80a8d749e4a46e54c5c13744c50f7e54264eb8d7..1ade76cdc7cca3dee6e77939ce65119407563bc2 100755 (executable)
--- a/mrlib.py
+++ b/mrlib.py
@@ -157,15 +157,19 @@ def verify_comments(comments, refs):
     return list(revs)
 
 def verify_commits(mrcommits, commits):
+    revs = set()
+    for commit in commits:
+        rev = verify_rev(commit)
+        revs.add(rev)
+
     mrc = set(mrcommits)
     mrc.add(rev_zero)
-    c = set(commits)
-    diff = c - mrc
+
+    diff = revs - mrc
     if diff:
         sys.exit("Invalid commits: {}".format(" ".join(diff)))
 
-    return commits
-
+    return list(revs)
 
 def add_tag(tags, mr, commit, tag, user, value):
     if mr not in tags: